qemu_guest_agent: adjust check method for isa-serial situation #3781
Conversation
|
@vivianQizhu could you please help to review? @MiriamDeng @fbq815 @BohdanMar does it affect your scenario? if so, please help to review it. |
|
since isa only support on x86, no affection on s390x |
|
This case isn't supported on aarch64, no affection. |
qemu/tests/qemu_guest_agent.py
Outdated
| log_str = session.cmd_output(get_log_cmd).strip().split('\n')[-1] | ||
| pattern = r"%s" % qga_cmd | ||
| if not re.findall(pattern, log_str, re.M | re.I): | ||
| if not log_str: |
There was a problem hiding this comment.
This would make the checkpoint meaningless, I would suggest to check at least the command return value if we don't check the detail content.
6-dehan
force-pushed
the
for-2199116-pass-qga-debug-output
branch
2 times, most recently
from
1e03fcc
to
5de31dc
Compare
…-shutdown-method
6-dehan
force-pushed
the
for-2199116-pass-qga-debug-output
branch
from
5de31dc
to
b718424
Compare
|
something goes wrong. |
since there is a minor change for starting qemu-ga.exe, it will display debug info about version of mingw-qemu-ga so that auto program couldn't catch the expected condition to determine cmd run finished. so remove invaluable parameter '-v' after confirm with dev.
ID: 2199116
Signed-off-by: demeng [email protected]